gh0s7/mckernel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix other warnings

Browse Source 
Most were harmless, but the change to ACCESS_ONCE from volatile
cast is probably useful.
Expanding macro, we basically went from:
    m = (volatile struct sdma_vl_map *)dd->sdma_map;
to
    m = *(volatile struct sdma_vl_map **)&(dd->sdma_map);
i.e. the explicit lookup is at a different level.
This commit is contained in:
Dominique Martinet
2017-09-15 11:16:36 +09:00
committed by Balazs Gerofi
parent 2dc85ee417
commit 7366da4390
5 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/sdma.c
View File

@ -808,7 +808,7 @@ struct sdma_engine *sdma_select_engine_vl(
rcu_read_lock();
m = rcu_dereference(dd->sdma_map);
#else
m = (volatile struct sdma_vl_map *)dd->sdma_map;
m = ACCESS_ONCE(dd->sdma_map);
#endif /* __HFI1_ORIG__ */
if (unlikely(!m)) {
#ifdef __HFI1_ORIG__
@ -1730,20 +1730,20 @@ void __sdma_txclean(
struct hfi1_devdata *dd,
struct sdma_txreq *tx)
{
u16 i;
if (tx->num_desc) {
/* TODO: enable sdma_unmap_desc */
#if 0
u16 i;
u8 skip = 0, mode = ahg_mode(tx);
/* TODO: enable sdma_unmap_desc */
/* unmap first */
//sdma_unmap_desc(dd, &tx->descp[0]);
/* determine number of AHG descriptors to skip */
if (mode > SDMA_AHG_APPLY_UPDATE1)
skip = mode >> 1;
/* TODO: enable sdma_unmap_desc */
// for (i = 1 + skip; i < tx->num_desc; i++)
// sdma_unmap_desc(dd, &tx->descp[i]);
#endif
tx->num_desc = 0;
}
kfree(tx->coalesce_buf);