release: 1.7.4: fix missing fput of executable

Change-Id: If3e2bb10bd21515876c5a37839cd9fcf12774329

CMakeLists.txt

@@ -7,7 +7,7 @@ endif (NOT CMAKE_BUILD_TYPE)
 enable_language(C ASM)
 
 project(mckernel C ASM)
-set(MCKERNEL_VERSION "1.7.3")
+set(MCKERNEL_VERSION "1.7.4")
 
 # See "Fedora Packaging Guidelines -- Versioning"
 set(MCKERNEL_RELEASE "")

executer/kernel/mcctrl/control.c

@@ -1799,8 +1799,7 @@ out:
 }
 
 LIST_HEAD(mckernel_exec_files);
-DEFINE_SEMAPHORE(mckernel_exec_file_lock);
+static DEFINE_SPINLOCK(mckernel_exec_file_lock);
- 
 
 struct mckernel_exec_file {
 	ihk_os_t os;
@@ -1977,6 +1976,7 @@ int mcexec_open_exec(ihk_os_t os, char * __user filename)
 	char *fullpath = NULL;
 	char *kfilename = NULL;
 	int len;
+	unsigned long flags;
 
 	if (os_ind < 0) {
 		return -EINVAL;
@@ -1991,38 +1991,39 @@ int mcexec_open_exec(ihk_os_t os, char * __user filename)
 	kfilename = kmalloc(PATH_MAX, GFP_KERNEL);
 	if (!kfilename) {
 		retval = -ENOMEM;
-		kfree(pathbuf);
 		goto out;
 	}
 
 	len = strncpy_from_user(kfilename, filename, PATH_MAX);
 	if (unlikely(len < 0)) {
 		retval = -EINVAL;
-		goto out_free;
+		goto out;
 	}
 
-	/* fget and list_add should be atomic */
+	/* fget and list_add should not be interrupted by hardware interrupt */
-	down(&mckernel_exec_file_lock);
+	spin_lock_irqsave(&mckernel_exec_file_lock, flags);
 
 	file = open_exec(kfilename);
 	retval = PTR_ERR(file);
 	if (IS_ERR(file)) {
-		up(&mckernel_exec_file_lock);
+		spin_unlock_irqrestore(&mckernel_exec_file_lock, flags);
-		goto out_free;
+		goto out;
 	}
 
 	fullpath = d_path(&file->f_path, pathbuf, PATH_MAX);
 	if (IS_ERR(fullpath)) {
-		up(&mckernel_exec_file_lock);
+		fput(file);
+		spin_unlock_irqrestore(&mckernel_exec_file_lock, flags);
 		retval = PTR_ERR(fullpath);
-		goto out_put_file;
+		goto out;
 	}
 
 	mcef = kmalloc(sizeof(*mcef), GFP_KERNEL);
 	if (!mcef) {
-		up(&mckernel_exec_file_lock);
+		fput(file);
+		spin_unlock_irqrestore(&mckernel_exec_file_lock, flags);
 		retval = -ENOMEM;
-		goto out_put_file;
+		goto out;
 	}
 	memset(mcef, 0, sizeof(struct mckernel_exec_file)); /* debug */
 
@@ -2046,22 +2047,15 @@ int mcexec_open_exec(ihk_os_t os, char * __user filename)
 	/* Create /proc/self/exe entry */
 	add_pid_entry(os_ind, task_tgid_vnr(current));
 	proc_exe_link(os_ind, task_tgid_vnr(current), fullpath);
-	up(&mckernel_exec_file_lock);
+	spin_unlock_irqrestore(&mckernel_exec_file_lock, flags);
 
 	dprintk("%d open_exec and holding file: %s\n", (int)task_tgid_vnr(current),
 			kfilename);
 
-	kfree(kfilename);
+	retval = 0;
-	kfree(pathbuf);
-
-	return 0;
-
-out_put_file:
-	fput(file);
-out_free:
-	kfree(pathbuf);
-	kfree(kfilename);
 out:
+	kfree(pathbuf);
+	kfree(kfilename);
 	return retval;
 }
 
@@ -2070,12 +2064,13 @@ int mcexec_close_exec(ihk_os_t os, int pid)
 	struct mckernel_exec_file *mcef = NULL;
 	int found = 0;
 	int os_ind = ihk_host_os_get_index(os);
+	unsigned long flags;
 
 	if (os_ind < 0) {
 		return EINVAL;
 	}
 
-	down(&mckernel_exec_file_lock);
+	spin_lock_irqsave(&mckernel_exec_file_lock, flags);
 	list_for_each_entry(mcef, &mckernel_exec_files, list) {
 		if (mcef->os == os && mcef->pid == pid) {
 			allow_write_access(mcef->fp);
@@ -2088,7 +2083,7 @@ int mcexec_close_exec(ihk_os_t os, int pid)
 		}
 	}
 
-	up(&mckernel_exec_file_lock);
+	spin_unlock_irqrestore(&mckernel_exec_file_lock, flags);
 
 	return (found ? 0 : EINVAL);
 }