From fcd8b0b892e8432f6a6aa057c9360e690e48f9ee Mon Sep 17 00:00:00 2001 From: Hansung Kim Date: Sat, 9 Nov 2024 20:37:58 -0800 Subject: [PATCH] flash: Disable rescale flag check GEMM-II finishes much earlier than softmax for this to be a problem. --- .../flash_attention/kernel.gemmini.cpp | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/regression/flash_attention/kernel.gemmini.cpp b/tests/regression/flash_attention/kernel.gemmini.cpp index 79079811..882d8f96 100644 --- a/tests/regression/flash_attention/kernel.gemmini.cpp +++ b/tests/regression/flash_attention/kernel.gemmini.cpp @@ -602,17 +602,17 @@ void kernel_body(int task_id, kernel_arg_t *__UNIFORM__ arg) { } #ifdef FENCE_GEMM_II - asm volatile("rescale_fence_read_start_%=:" ::); - // check flag to make sure GEMM II finished and read-after-write - // dependency on O tile is settled for rescale - if (tid_in_warpgroup == 0) { - while ((*smem_O_flag) != 1) - ; - // set it back to 0 for the next tile iteration - *smem_O_flag = 0; - vx_fence(); - } - asm volatile("rescale_fence_read_end_%=:" ::); + // asm volatile("rescale_fence_read_start_%=:" ::); + // // check flag to make sure GEMM II finished and read-after-write + // // dependency on O tile is settled for rescale + // if (tid_in_warpgroup == 0) { + // while ((*smem_O_flag) != 1) + // ; + // // set it back to 0 for the next tile iteration + // *smem_O_flag = 0; + // vx_fence(); + // } + // asm volatile("rescale_fence_read_end_%=:" ::); #endif #if 0