From 40565de8cd18f2b1f2441022c0ca32f14567ec7a Mon Sep 17 00:00:00 2001 From: Hansung Kim Date: Thu, 24 Oct 2024 16:41:54 -0700 Subject: [PATCH] tensor: Fix initiate sync with meta queue when !commit.ready --- hw/rtl/core/VX_tensor_hopper_core.sv | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/rtl/core/VX_tensor_hopper_core.sv b/hw/rtl/core/VX_tensor_hopper_core.sv index ad79ac1a..ad661301 100644 --- a/hw/rtl/core/VX_tensor_hopper_core.sv +++ b/hw/rtl/core/VX_tensor_hopper_core.sv @@ -89,7 +89,9 @@ module VX_tensor_hopper_core_block import VX_gpu_pkg::*; #( wire hmma_wait = metadata_valid && (execute_if_data_op_type == `INST_TENSOR_HGMMA_WAIT); // skip HGMMA_WAIT for kickoff - wire initiate_valid = metadata_valid && !hmma_wait; + // should be metadata_deq not metadata_valid, since initiate should be + // synced with metadata->commit path + wire initiate_valid = metadata_deq && !hmma_wait; wire [`NW_WIDTH-1:0] initiate_wid = execute_if_data_wid; // we're recycling execute_if.op_type as operands_if.op_type which might