- remove unused GA build-extra-tests/action.yml

- cleanup exports in CA
  - remove exports from build-extra-tests CA
  - put exports in build-extra-tests.sh
    - based it on $GITHUB_WORKSPACE
  - changed exports in run-tests CA to use $GITHUB_WORKSPACE
- in common.mk
  - removed TODO comment lines where `$(sim)` had been removed
  - removed commented out lines that used `$(sim)`
- removed unused debugging script1.sh

.github/actions/build-extra-tests/action.yml

@@ -1,28 +0,0 @@
-name: build-extra-tests
-description: 'Builds extra test required for FireSim tests'
-
-inputs:
-  tools-version:
-    description: Which toolchain to build
-    required: false
-    default: 'riscv-tools'
-  cache-key:
-    description: Use this for caching
-    required: true
-runs:
-  using: "composite"
-  steps:
-    - uses: actions/cache@v2
-      id: build-extra-tools-cache
-      with:
-        path: extra-tests-install
-        key: ${{ needs.make-keys.outputs.extra-tests-cache-key }}
-        restore-keys: ${{ needs.make-keys.outputs.extra-tests-cache-key }}
-    - name: Build extra tests if not cached
-      run: |
-        export RISCV="/__w/chipyard/chipyard/riscv-tools-install"
-        export LD_LIBRARY_PATH="$RISCV/lib"
-        export PATH="$RISCV/bin:$PATH"
-        .github/scripts/build-extra-tests.sh
-      shell: bash
-

.github/actions/run-tests/action.yml

@@ -15,7 +15,7 @@ runs:
   steps:
     - name: run rtl build script cache of chipyard root should have been loaded by prepare-rtl
       run: |
-        export RISCV="/__w/chipyard/chipyard/riscv-tools-install"
+        export RISCV="$GITHUB_WORKSPACE/riscv-tools-install"
         export LD_LIBRARY_PATH="$RISCV/lib"
         export PATH="$RISCV/bin:$PATH"
         ./.github/scripts/${{ inputs.run-script }} ${{ inputs.project-key }}

.github/scripts/build-extra-tests.sh

@@ -3,6 +3,10 @@
 # turn echo on and error on earliest command
 set -ex
 
+export RISCV="$GITHUB_WORKSPACE/riscv-tools-install"
+export LD_LIBRARY_PATH="$RISCV/lib"
+export PATH="$RISCV/bin:$PATH"
+
 # get shared variables
 SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
 source $SCRIPT_DIR/defaults.sh

.github/workflows/chipyard-run-tests.yml

@@ -140,11 +140,7 @@ jobs:
           key: ${{ needs.make-keys.outputs.extra-tests-cache-key }}
           restore-keys: ${{ needs.make-keys.outputs.extra-tests-cache-key }}
       - name: Build extra tests if not cached
-        run:  |
-          export RISCV="/__w/chipyard/chipyard/riscv-tools-install"
-          export LD_LIBRARY_PATH="$RISCV/lib"
-          export PATH="$RISCV/bin:$PATH"
-          .github/scripts/build-extra-tests.sh
+        run: .github/scripts/build-extra-tests.sh
 
   install-verilator:
     name: install-verilator