wu-arch/kernels
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

flash: Disable rescale flag check

Browse Source 
GEMM-II finishes much earlier than softmax for this to be a problem.
This commit is contained in:
Hansung Kim
2024-11-09 20:37:58 -08:00
parent 1c9b022156
commit fcd8b0b892
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/regression/flash_attention/kernel.gemmini.cpp
View File

@@ -602,17 +602,17 @@ void kernel_body(int task_id, kernel_arg_t *__UNIFORM__ arg) {
}
#ifdef FENCE_GEMM_II
asm volatile("rescale_fence_read_start_%=:" ::);
// check flag to make sure GEMM II finished and read-after-write
// dependency on O tile is settled for rescale
if (tid_in_warpgroup == 0) {
while ((*smem_O_flag) != 1)
;
// set it back to 0 for the next tile iteration
*smem_O_flag = 0;
vx_fence();
}
asm volatile("rescale_fence_read_end_%=:" ::);
// asm volatile("rescale_fence_read_start_%=:" ::);
// // check flag to make sure GEMM II finished and read-after-write
// // dependency on O tile is settled for rescale
// if (tid_in_warpgroup == 0) {
// while ((*smem_O_flag) != 1)
// ;
// // set it back to 0 for the next tile iteration
// *smem_O_flag = 0;
// vx_fence();
// }
// asm volatile("rescale_fence_read_end_%=:" ::);
#endif
#if 0