wu-arch/vortex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add issue-stall-by-operand-hazard perf counters

Browse Source 
Do the same reduce by + instead of OR fix for scoreboard counters.
This commit is contained in:
Hansung Kim
2024-03-23 00:00:08 -07:00
parent dda67da84c
commit 573be030c8
1 changed files with 46 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
hw/rtl/core/VX_scoreboard.sv
View File

@@ -34,46 +34,73 @@ module VX_scoreboard import VX_gpu_pkg::*; #(
`ifdef PERF_ENABLE
reg [`ISSUE_WIDTH-1:0][`NUM_EX_UNITS-1:0] perf_issue_units_per_cycle;
wire [`NUM_EX_UNITS-1:0] perf_units_per_cycle, perf_units_per_cycle_r;
wire [`NUM_EX_UNITS-1:0][`PERF_CTR_BITS-1:0] perf_units_per_cycle_r;
reg [`NUM_EX_UNITS-1:0][`PERF_CTR_BITS-1:0] perf_units_per_cycle;
reg [`ISSUE_WIDTH-1:0][`NUM_SFU_UNITS-1:0] perf_issue_sfu_per_cycle;
wire [`NUM_SFU_UNITS-1:0] perf_sfu_per_cycle, perf_sfu_per_cycle_r;
wire [`NUM_SFU_UNITS-1:0][`PERF_CTR_BITS-1:0] perf_sfu_per_cycle_r;
reg [`NUM_SFU_UNITS-1:0][`PERF_CTR_BITS-1:0] perf_sfu_per_cycle;
wire [`ISSUE_WIDTH-1:0] perf_issue_stalls_per_cycle;
wire [`CLOG2(`ISSUE_WIDTH+1)-1:0] perf_stalls_per_cycle, perf_stalls_per_cycle_r;
wire [`ISSUE_WIDTH-1:0] perf_issue_fires_per_cycle;
wire [`CLOG2(`ISSUE_WIDTH+1)-1:0] perf_fires_per_cycle, perf_fires_per_cycle_r;
`POP_COUNT(perf_stalls_per_cycle, perf_issue_stalls_per_cycle);
`POP_COUNT(perf_fires_per_cycle, perf_issue_fires_per_cycle);
reg [`PERF_CTR_BITS-1:0] perf_scb_fires;
for (genvar i=0; i < `NUM_EX_UNITS; ++i) begin
always @(*) begin
perf_units_per_cycle[i] = '0;
for (integer isw = 0; isw < `ISSUE_WIDTH; ++isw) begin
perf_units_per_cycle[i] = perf_units_per_cycle[i] + perf_issue_units_per_cycle[isw][i];
end
end
end
for (genvar i=0; i < `NUM_SFU_UNITS; ++i) begin
always @(*) begin
perf_sfu_per_cycle[i] = '0;
for (integer isw = 0; isw < `ISSUE_WIDTH; ++isw) begin
perf_sfu_per_cycle[i] = perf_sfu_per_cycle[i] + perf_issue_sfu_per_cycle[isw][i];
end
end
end
// NOTE(hansung): Because of OR-reduce, things are counted as once even when
// multiple warps were using the same execution unit type at a given cycle.
// This might result in an overall undercount
VX_reduce #(
.DATAW_IN (`NUM_EX_UNITS),
.N (`ISSUE_WIDTH),
.OP ("|")
) perf_units_reduce (
.data_in (perf_issue_units_per_cycle),
.data_out (perf_units_per_cycle)
);
// VX_reduce #(
// .DATAW_IN (`NUM_EX_UNITS),
// .N (`ISSUE_WIDTH),
// .OP ("|")
// ) perf_units_reduce (
// .data_in (perf_issue_units_per_cycle),
// .data_out (perf_units_per_cycle)
// );
VX_reduce #(
.DATAW_IN (`NUM_SFU_UNITS),
.N (`ISSUE_WIDTH),
.OP ("|")
) perf_sfu_reduce (
.data_in (perf_issue_sfu_per_cycle),
.data_out (perf_sfu_per_cycle)
);
// VX_reduce #(
// .DATAW_IN (`NUM_SFU_UNITS),
// .N (`ISSUE_WIDTH),
// .OP ("|")
// ) perf_sfu_reduce (
// .data_in (perf_issue_sfu_per_cycle),
// .data_out (perf_sfu_per_cycle)
// );
`BUFFER(perf_stalls_per_cycle_r, perf_stalls_per_cycle);
`BUFFER(perf_fires_per_cycle_r, perf_fires_per_cycle);
`BUFFER(perf_units_per_cycle_r, perf_units_per_cycle);
`BUFFER(perf_sfu_per_cycle_r, perf_sfu_per_cycle);
always @(posedge clk) begin
if (reset) begin
perf_scb_stalls <= '0;
perf_scb_fires <= '0;
end else begin
perf_scb_stalls <= perf_scb_stalls + `PERF_CTR_BITS'(perf_stalls_per_cycle_r);
perf_scb_fires <= perf_scb_fires + `PERF_CTR_BITS'(perf_fires_per_cycle_r);
end
end
@@ -153,6 +180,7 @@ module VX_scoreboard import VX_gpu_pkg::*; #(
end
end
assign perf_issue_stalls_per_cycle[i] = ibuffer_if[i].valid && ~ibuffer_if[i].ready;
assign perf_issue_fires_per_cycle[i] = ibuffer_if[i].valid && ibuffer_if[i].ready;
`endif
// NOTE(hansung): why is inuse_rd checked? to prevent WAW?